VMSS bug fix + tidying up #632

BurtBiel · 2016-08-05T17:37:54Z

Unify help text for folded params. Fix VMSS issue with no-LB option. Add tests for creating smallest set of resources for VM and VMSS.

Updated help for VMSS

Command
    az vmss create: Create an Azure Virtual Machine Scale Set.
        See https://azure.microsoft.com/en-us/blog/azure-virtual-machine-scale-sets-ga/ for an
        introduction to scale sets.

Arguments
    --name -n              [Required]: The VM name.
    --resource-group -g    [Required]: Name of resource group.
    --admin-password                 : Password for the Virtual Machine if Authentication Type is
                                       Password.
    --admin-username                 : Username for the Virtual Machine.  Default: burtbiel.
    --authentication-type            : Password or SSH public key authentication. Defaults to
                                       password for Windows and SSH public key for Linux.  Allowed
                                       values: ssh, password.
    --custom-os-disk-type            : Custom image OS type.  Default: windows.
    --disable-overprovision          : Overprovision option (see https://azure.microsoft.com/en-
                                       us/documentation/articles/virtual-machine-scale-sets-
                                       overview/ for details).
    --image                          : OS image (URN alias, URN or URI).  Default:
                                       Win2012R2Datacenter.
        URN aliases: CentOS, CoreOS, Debian, openSUSE, RHEL, SLES, UbuntuLTS, Win2008SP1,
        Win2012Datacenter, Win2012R2Datacenter.
        Example URN: MicrosoftWindowsServer:WindowsServer:2012-R2-Datacenter:latest.
        Example URI: http://<storageAccount>.blob.core.windows.net/vhds/osdiskimage.vhd.

    --instance-count                 : Number of VMs in scale set.  Default: 2.
    --load-balancer                  : Name or ID of the resource.  Creates new by default.  Use ""
                                       for none.
    --load-balancer-backend-pool-name: Name of load balancer backend pool.
    --location -l                    : Location.
    --os-disk-name                   : Name of new VM OS disk.  Default: osdiskimage.
    --public-ip-address              : Name or ID of the resource.  Creates new by default.  Use ""
                                       for none.
    --public-ip-address-allocation   : Allowed values: dynamic, static.  Default: dynamic.
    --public-ip-address-dns-name     : Globally unique DNS Name for the Public IP.
    --ssh-dest-key-path              : Destination file path on VM for SSH key.
    --ssh-key-value                  : SSH key file data.
    --storage-caching                : Storage caching type.  Default: ReadOnly.
    --storage-container-name         : Name of storage container for the VM OS disk.  Default: vhds.
    --storage-type                   : The VM storage type.  Default: Standard_LRS.
    --subnet-ip-address-prefix       : The subnet address prefix in CIDR format.  Default:
                                       10.0.0.0/24.
    --subnet-name                    : The subnet name.  Creates if creating a new VNet, references
                                       if referencing an existing VNet.
    --tags                           : Multiple semicolon separated tags in 'key[=value]' format.
                                       Use "" for none.
    --upgrade-policy-mode            : Allowed values: automatic, manual.  Default: manual.
    --vm-sku                         : Size of VMs in the VM Scale Set.  See
                                       https://azure.microsoft.com/en-us/pricing/details/virtual-
                                       machines/ for size info.  Default: Standard_D1_v2.
    --vnet                           : Name or ID of the resource.  Uses existing by default or
                                       creates if none found.
    --vnet-ip-address-prefix         : The virtual network IP address prefix in CIDR format.
                                       Default: 10.0.0.0/16.

tjprescott · 2016-08-05T22:57:36Z

src/azure/cli/commands/template_create.py

is cannot [](start = 41, length = 9)

Typo: remove 'is'. #Resolved

tjprescott · 2016-08-05T23:02:20Z

…Add tests for creating smallest set of resources for VM and VMSS.

…changes, so this is commented out. It is covered by the work item to uncomment the test below it.

* Unify help text for folded params. Fix VMSS issue with no-LB option. Add tests for creating smallest set of resources for VM and VMSS. * Disabling role test, VCR exceptions were getting eaten, which my fix changes, so this is commented out. It is covered by the work item to uncomment the test below it.

* [image-copy] update to version 0.2.0 * [image-copy] update index for version 0.2.0 * switch to 2019-04-01 api version and enable windows agent pool (Azure#612) * fixing az support for agent pools and mc * vendor in 2019-04-01 SDK * enableing windows profile * merge the latest official SDK * add secure prompt for windows admin password * fixing warnings * Policies should be global, remove location parameter and default it (Azure#620) * bug fixes: missing service principal and network profile parameter validation (Azure#626) * Pin max CLI version. (Azure#630) * Update front door index to 0.1.5 (Azure#632) * Fixes Azure#629. (Azure#631) * Update index.json. (Azure#640) * Add new version of aks-preview in index.json (Azure#634) * Azure Event Grid 0.4.1 (Azure#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (Azure#641) * [storage-preview] release azcopy 10.0.9 (Azure#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (Azure#642) * App Insights control plane (Azure#600) * Remove 'preview' from Dev Spaces (Azure#638) * Update PULL_REQUEST_TEMPLATE.md (Azure#645) Refer to azdev. * setting default vm size for windows (Azure#637) * SQL: make "up" command work end to end (Azure#644) * Update requirements.txt Bump for Jinja security vulnerability * Update to RP standard release 3.5 (Azure#29) (Azure#627) * NFSAAS-2102 update to R3.5 (Azure#29) * Nfsaas 2102 update to r3 5 (Azure#30) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * Nfsaas 2102 update to r3 5 (Azure#31) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#32) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#33) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#34) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#35) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#36) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#37) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#38) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#39) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Nfsaas 2102 update to r3 5 (Azure#40) * NFSAAS-2102 update to R3.5 * NFSAAS-2102 update to RP R3.5 standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * NFSAAS-2102 update to R3.5 RP standard * Merge azure master back to fork. (Azure#41) * Add new version of aks-preview in index.json (Azure#634) * Azure Event Grid 0.4.1 (Azure#633) * Azure Event Grid 0.4.1 * fix white space * fix style issues * style fixes * style comment spaces fixes * more style fixes * mossing hesder * Address CR comment * move json generated SDK files to vendored_sdks folder and update related imports * revert index changes until we publish final extension * Address CR comments by removing unnecessary parameters * Fix style * update index.json file * fix index.json after running azdev extension update-index * fix index.json after running azdev extension update-index * add missing __init__.py * fix init files * fix new line in init files * update location of vendored_sdks and update index.json * fix help errors and update index.json file accordingly * [aks-preview]: fix python3-only super() syntax (Azure#641) * [storage-preview] release azcopy 10.0.9 (Azure#639) * [storage-preview] release azcopy 10.0.9 * Fix indent * [storage-preview] pulish 0.2.4 (Azure#642) * App Insights control plane (Azure#600) * Remove 'preview' from Dev Spaces (Azure#638) * Update PULL_REQUEST_TEMPLATE.md (Azure#645) Refer to azdev. * setting default vm size for windows (Azure#637) * SQL: make "up" command work end to end (Azure#644) * Update requirements.txt Bump for Jinja security vulnerability * Update readme to reflect the latest SQL DB status * SQL up: update a typo * Update index.json for backwards compatability for Dev Spaces (Azure#648) * update index.json for backwards compatability * fix maxCliVersion for dev-spaces-preview * revert dev-spaces minCliCoreVersion * update metadata for dev-spaces and dev-spaces-preview * update metadata for dev-spaces and dev-spaces-preview * sync workspaces * 0.5.0 release for Azure DevOps (Azure#653) * [AKS]customizing node resource group (Azure#636) * customizing node resource group * make 2.0 and 3.0 python work * add index * Onboard Azure Machine Learning Service CLI (Azure#655) * [storage-preview] pulish 0.2.5 (Azure#657) * [AKS] Add Azure policy addon (Azure#651) * Add the Azure Policy Addon Support * Add azure-policy addon * Allow azure-policy addon in create * Update the index * Add the missing parameter description * 0.6.0 release for Azure DevOps (Azure#660) * Upgrade AppConfig extension version from 0.4.0 to 0.5.0 (Azure#661) * Upgrade AppConfig extension verstion from 0.4.0 to 0.5.0 * format downloadUrl * update wheel version to 0.30.0 * Update service principal secret for windows nodes (Azure#662) * Release storage-preview 0.2.5 (Azure#663) * Remove extra + (Azure#664) * 0.7.0 release for Azure DevOps (Azure#666) * 0.7.0 release for Azure DevOps * update sha * fix * remove botservice from index.json (Azure#667) * [image-copy] fix temp_rg default valuet

azurecla added the cla-not-required label Aug 5, 2016

BurtBiel assigned tjprescott Aug 5, 2016

BurtBiel force-pushed the commands/CreateVMSS branch 2 times, most recently from d87e99e to d39d513 Compare August 5, 2016 20:33

tjprescott reviewed Aug 5, 2016
View reviewed changes

BurtBiel force-pushed the commands/CreateVMSS branch from d39d513 to 5cf32c6 Compare August 5, 2016 23:05

BurtBiel added 2 commits August 5, 2016 16:29

Unify help text for folded params. Fix VMSS issue with no-LB option. …

b6183f0

…Add tests for creating smallest set of resources for VM and VMSS.

Disabling role test, VCR exceptions were getting eaten, which my fix …

fc8743e

…changes, so this is commented out. It is covered by the work item to uncomment the test below it.

BurtBiel force-pushed the commands/CreateVMSS branch from 5cf32c6 to fc8743e Compare August 5, 2016 23:49

BurtBiel merged commit 97574f2 into Azure:master Aug 5, 2016

haroldrandom added the cla-not-required label Oct 25, 2019

00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021

Update front door index to 0.1.5 (Azure#632)

b3d9895

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

VMSS bug fix + tidying up #632

VMSS bug fix + tidying up #632

Uh oh!

BurtBiel commented Aug 5, 2016 •

edited

Loading

Uh oh!

tjprescott Aug 5, 2016 •

edited by BurtBiel

Loading

Uh oh!

tjprescott commented Aug 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VMSS bug fix + tidying up #632

VMSS bug fix + tidying up #632

Uh oh!

Conversation

BurtBiel commented Aug 5, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tjprescott Aug 5, 2016 • edited by BurtBiel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tjprescott commented Aug 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BurtBiel commented Aug 5, 2016 •

edited

Loading

tjprescott Aug 5, 2016 •

edited by BurtBiel

Loading